nit: returning NULL with no explanation is not cool #18543
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+232
to
+240
| if (dbh->error_mode == PDO_ERRMODE_EXCEPTION) { | ||
| zend_throw_exception_ex( | ||
| php_pdo_get_exception(), 0, | ||
| "SQLite PDO::quote: string is too long to quote"); | ||
| } else if (dbh->error_mode == PDO_ERRMODE_WARNING) { | ||
| php_error_docref( | ||
| NULL, E_WARNING, | ||
| "string is too long to quote"); | ||
| } |
There was a problem hiding this comment.
How about using pdo_raise_impl_error() for SQLSTATE 22001?
There was a problem hiding this comment.
hmm, should it use 22001 regardless of error mode, or should it use 22001 for exception and 01004 otherwise?
There was a problem hiding this comment.
Since 01004 is a warning that occurs when read data is discarded for instance, when the buffer is too small, I believe that in every case, 22001 is the appropriate choice.
edit:
Since this distinction is made in systems like DB2 and ODBC, 01004 is generally considered to be related to fetch operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.